gemmellr commented on code in PR #4824:
URL: https://github.com/apache/activemq-artemis/pull/4824#discussion_r1517786516
##########
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java:
##########
@@ -88,6 +90,124 @@ public void testSendMessage() throws Exception {
checkSentMessages(session, address, null);
}
+ @Test
+ public void testBooleanMessageProperties() throws Exception {
Review Comment:
I pushed another commit that switches the unit tests to be more granular as
with the original tests, and use a mocked message that gets rid of the large
test impl More succinct, and verifies just the ProducerThread behaviour rather
than also testing the test-msg-impl as the prior tests were really doing.
I also restored a basic integration test, since ProducerThreadTest doesnt
really cover that the option is actually entirely wired through correctly and
is effective in practice, and cant really without heavily reworking
Producer+ProducerThread so that a unit test really could verify things from
initial command to the point of 'this message is whats about to be sent'
without still standing up the broker + producer etc.
If you like the changes, just squash them and push...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
