cshannon commented on PR #1172: URL: https://github.com/apache/activemq/pull/1172#issuecomment-2015202036
I should also add the caveat that while I said in my last comment I think it makes no sense to stick with the `TaskRunner` interface that there is still a possibility we may ultimately need to. We have a lot of custom code and impl there so we need to really dive into it to see if we can get rid of it or not or if we need to keep parts of it. There's also the possibility that we could refactor it but it's so much work it isn't worth it, but I hope not. My initial assumption is we _should_ be able to refactor things with modern concurrent features of java and get rid of some of that but obviously TBD. So, I don't think you should delete any of this code as maybe we end up having to use the new virtual thread task runner you created, but since that's TBD and also a tech preview that is being tested, for now I think it's best in another branch for until we figure out the plan. I think we should take a look into the current implementations and see if they can be removed or improve/simplified as part of this. I can take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
