cshannon commented on PR #1172: URL: https://github.com/apache/activemq/pull/1172#issuecomment-2317628563
So I will say that maintaining another branch can be a bit of a pain so I think the other option I would be ok with if we want to release this now would be to just improve the documentation a lot. The feature is of course marked as a tech preview and experimental but it's not super clear as to the drawbacks or warnings if you try and use it. This [page](https://activemq.apache.org/components/classic/documentation/virtual-threads) only currently lists benefits and why you would want to use it so it's kind of almost tempting an end user to want to turn it on prematurely. So I think maybe the following: 1. Update the [documentation](https://activemq.apache.org/components/classic/documentation/virtual-threads) page to talk about more about the current state and how far a long the implementation is. We should make it clear it's just for testing and evaluation and basically define why it's a Tech Preview and experimental. 2. The page has a benefits section but we could also add a section on potential problems and warnings for now. 3. Update all the Javadocs for the new classes to give information on potential warnings and pitfalls. They are marked with the experimental annotation but there's not a lot of information as to why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
