kenliao94 commented on code in PR #1247:
URL: https://github.com/apache/activemq/pull/1247#discussion_r1671414742
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/SelectorAwareVirtualTopicInterceptor.java:
##########
@@ -37,12 +39,15 @@
public class SelectorAwareVirtualTopicInterceptor extends
VirtualTopicInterceptor {
private static final Logger LOG =
LoggerFactory.getLogger(SelectorAwareVirtualTopicInterceptor.class);
LRUCache<String,BooleanExpression> expressionCache = new
LRUCache<String,BooleanExpression>();
- private final SubQueueSelectorCacheBroker selectorCachePlugin;
Review Comment:
Could we keep this final and at line 47 we do:
```
selectorCachePlugin = (baseDestination != null) ?
(SubQueueSelectorCacheBroker)
baseDestination.createConnectionContext().getBroker().getAdaptor(SubQueueSelectorCacheBroker.class)
: null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
