Nikita-Shupletsov commented on PR #1247: URL: https://github.com/apache/activemq/pull/1247#issuecomment-2221666756
> 1. This change needs to be a JIRA Done. https://issues.apache.org/jira/browse/AMQ-9530 > 2. This needs a unit test with an example configured w/ another DestinationFilter on top of Virtual Topic Updated `VirtualTopicSelectorTest,` as it's basically tests `SelectorAwareVirtualTopicInterceptor`. Also used it to initially reproduce the issue(see the ticket). > 3. If we are going to fix it, we should adapt all the Virtual Destinations to use the same set of methods. There are no issues like this in other pars of the Virtual Destination code. only in `SelectorAwareVirtualTopicInterceptor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
