cshannon commented on PR #1364: URL: https://github.com/apache/activemq/pull/1364#issuecomment-2539155655
@kenliao94 - Yeah I think it's probably simplest to just do the one message at a time thing (don't even have an option to turn it off). The new method should be spec compliant so if we just go with blocking until the completion completes that works. The main thing is to make sure the completion handler still runs in a new thread (so use an executor, etc). This is still not going to be slow, it will be as fast as the normal sync API which is still quite fast, it just limits the concurrent sends until we can handle ordering. It ends up just being similar to sync but allows using the callback to handle which can be nice for some use cases. As you said, we can just keep the existing API with current async behavior so users can retain that if they want multiple concurrent sends and a future update could handle ordering if we want to support multiple concurrent sends for the new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
