kenliao94 commented on PR #1364: URL: https://github.com/apache/activemq/pull/1364#issuecomment-2536928048
Hi @cshannon so the goal here is to implement the behavior as close to the spec as possible. There are 9 items in the spec, so are we saying that only 7.3.3 message orders is not met? In another words: 7.3.1 - met 7.3.2 - met 7.3.3 - not met 7.3.4 - met 7.3.5 - no going to support it, met 7.3.6 - not going to throw exception, it is application responsibility, met 7.3.7 - met 7.3.8 - I thought this is already met, but it seems like it has 7.3.9 - not going to throw exception, it is application responsibility, met The first iteration of this PR is to just wrap AsyncCallback into CompletionListener and have the CompletionListener implemented the same way as the original AsyncCallback. But as @tabish121 pointed out that version didn't implement the spec from the mailing list discussion https://lists.apache.org/thread/y2pz4y1p9c5l1cdm6lyd5spc810mk6kq we want to keep both behavior in ActiveMQ 6. Hence I created another PR that referenced the current design but added additional logic (wrapping user completion listener to perform check) I will do more testing and add more logic to try and meet 7.3.3. But would like to get clarity on whether this is the only one not meeting the spec or there are more. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
