gemmellr commented on code in PR #5395:
URL: https://github.com/apache/activemq-artemis/pull/5395#discussion_r1882391513
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/bean/MetaBean.java:
##########
@@ -123,10 +123,9 @@ public void parseToJSON(T object, JsonObjectBuilder
builder, boolean ignoreNullA
}
} else if (type == Boolean.class) {
builder.add(name, (Boolean) value);
+ /* This is the same as the default, but keeping this in case we
have to deal with Enums in the future
} else if (Enum.class.isAssignableFrom(type)) {
- // I know this is the same as the default else clause further
down
- // but i wanted to have a separate branch in case we have to
deal with it later
- builder.add(name, String.valueOf(value));
+ builder.add(name, String.valueOf(value));*/
Review Comment:
Ick. Maybe better just deleted at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
