gemmellr commented on PR #5395: URL: https://github.com/apache/activemq-artemis/pull/5395#issuecomment-2539410499
I'm fine with the other changes, they make sense overall, but are only being done due to the upgrade so it seems reaosonable enough to bundle them. I just think the commented-out-code shouldnt be there, better nothing. I did also type and delete 'maybe we could disable/downgrade-to-warning that new check?' before suggesting just to delete the comment since I'm fine with the changes. I'm also fine with duplicate branches where its clearer though, so I'd be fine without the check also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
