gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934296423
##########
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java:
##########
@@ -229,8 +229,8 @@ public Object evaluate(Filterable message) throws
FilterException {
if (lv == rv || lv.equals(rv)) {
return Boolean.TRUE;
}
- if (lv instanceof Comparable && rv instanceof Comparable) {
- return compare((Comparable) lv, (Comparable) rv);
+ if (lv instanceof Comparable comparable && rv instanceof
Comparable comparable1) {
+ return compare(comparable, comparable1);
Review Comment:
Names need updater or its far readable as it originally was.
Same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
