gemmellr commented on PR #5477: URL: https://github.com/apache/activemq-artemis/pull/5477#issuecomment-2622451998
finally done looking through the commits. Left 'a couple' of comments hehe. The last commit however, I didnt comment on lots of things that were just more of the same (I noted where in some cases). For example there are lots of instanceof pattern match name additions like byte1/long1/\<other\>1, or \<last-letter-of-type-prefix\>Exception, that make the code far less readable than it was to begin with with the original variable name and a cast. I think the entire commit needs be swept for those and updated before its fit to go in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
