jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2326352467


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/Connection.java:
##########
@@ -135,10 +135,25 @@ default void disconnect() {
    }
 
    /**
-    * {@return the string representation of the remote address this connection 
is connected to}
+    * {@return a string representation of the remote address of this 
connection; if this connection is made via the
+    * proxy protocol then this will be the original address, not the proxy 
address}

Review Comment:
   I changed my mind on this and confined the changes to 
`NettyServerConnection`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to