jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2330494969


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerField.java:
##########
@@ -33,6 +33,8 @@ public enum ConsumerField {
    CLIENT_ID("clientID"),
    LOCAL_ADDRESS("localAddress"),
    REMOTE_ADDRESS("remoteAddress"),
+   PROXY_ADDRESS("proxyAddress"),
+   PROXY_VERSION("proxyVersion"),

Review Comment:
   Originally I only had the new fields on the connection, but then I saw that 
`remoteAddress` was on the consumer & producer so I thought perhaps folks would 
expect the new fields there as well.
   
   I agree that repeating the fields across the different "views" is not ideal. 
I'll remove them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to