gemmellr commented on PR #5908: URL: https://github.com/apache/activemq-artemis/pull/5908#issuecomment-3275503139
I havent had a chance to look properly at this after all the changes yet...but skimming the tests, I only see spotted positive tests where it was expected to work and did. We should have negative tests for this, verifying connecting doesnt work when proxyProtocolEnabled=true and a connection connects without the header and vice versa fails when proxyProtocolEnabled=false (/defaulted) a connection with the proxy-protocol header comes in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
