jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2344590083
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java:
##########
@@ -525,13 +530,13 @@ private static int parseDefaultVariable(String
variableName, int defaultValue) {
allowableConnectorKeys.add(TransportConstants.NIO_REMOTING_THREADS_PROPNAME);
allowableConnectorKeys.add(TransportConstants.REMOTING_THREADS_PROPNAME);
allowableConnectorKeys.add(TransportConstants.BATCH_DELAY);
- allowableConnectorKeys.add(TransportConstants.PROXY_ENABLED_PROP_NAME);
- allowableConnectorKeys.add(TransportConstants.PROXY_HOST_PROP_NAME);
- allowableConnectorKeys.add(TransportConstants.PROXY_PORT_PROP_NAME);
+ allowableConnectorKeys.add(TransportConstants.SOCKS_ENABLED_PROP_NAME);
+ allowableConnectorKeys.add(TransportConstants.SOCKS_HOST_PROP_NAME);
+ allowableConnectorKeys.add(TransportConstants.SOCKS_PORT_PROP_NAME);
allowableConnectorKeys.add(TransportConstants.PROXY_VERSION_PROP_NAME);
- allowableConnectorKeys.add(TransportConstants.PROXY_USERNAME_PROP_NAME);
- allowableConnectorKeys.add(TransportConstants.PROXY_PASSWORD_PROP_NAME);
-
allowableConnectorKeys.add(TransportConstants.PROXY_REMOTE_DNS_PROP_NAME);
+ allowableConnectorKeys.add(TransportConstants.SOCKS_USERNAME_PROP_NAME);
Review Comment:
Not sure how I missed that before. Fixed now.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionField.java:
##########
@@ -29,7 +29,9 @@ public enum ConnectionField {
LOCAL_ADDRESS("localAddress"),
SESSION_ID("sessionID"),
CREATION_TIME("creationTime"),
- IMPLEMENTATION("implementation");
+ IMPLEMENTATION("implementation"),
+ PROXY_ADDRESS("proxyAddress"),
+ PROXY_VERSION("proxyVersion");
Review Comment:
Done.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java:
##########
@@ -65,7 +66,9 @@ public JsonObjectBuilder toJson(RemotingConnection
connection) {
.add(ConnectionField.PROTOCOL.getName(),
toString(connection.getProtocolName()))
.add(ConnectionField.CLIENT_ID.getName(),
toString(connection.getClientID()))
.add(ConnectionField.LOCAL_ADDRESS.getName(),
toString(connection.getTransportLocalAddress()))
- .add(ConnectionField.SESSION_COUNT.getName(), sessions.size());
+ .add(ConnectionField.SESSION_COUNT.getName(), sessions.size())
+ .add(ConnectionField.PROXY_ADDRESS.getName(),
toString(NettyServerConnection.getProxyAddress(connection.getTransportConnection())))
+ .add(ConnectionField.PROXY_VERSION.getName(),
toString(NettyServerConnection.getProxyVersion(connection.getTransportConnection())));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
