gemmellr commented on code in PR #5956:
URL: https://github.com/apache/activemq-artemis/pull/5956#discussion_r2420795555
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java:
##########
@@ -219,6 +220,16 @@ default void disconnect(DisconnectReason reason, String
targetNodeID, TransportC
*/
Subject getSubject();
+ /**
+ * sets the associated certificates for this connection
+ */
+ void setCertificates(X509Certificate[] certificates);
Review Comment:
I see Justin was suggesting NettyServerConnection, I actually misread that,
I was more thinking the NettyConnection impl class per my comment about the
related instanceof already being in place (in CertificateUtil). Even though
that class is also used in the client it would at least keep the setter off the
interfaces where it shouldnt be, and avoid need for dummy impl in other
classes. The related code is only called for that class, so it could perhaps
even be moved there with just a getter then needed.
You definitely cant add an `artemis-server` dependency to
`artemis-core-client`, since the former already depends on the latter so it
would form a loop and Maven simply wouldnt allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
