gemmellr commented on code in PR #5956:
URL: https://github.com/apache/activemq-artemis/pull/5956#discussion_r2428863909
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -49,7 +49,7 @@
import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPMirrorBrokerConnectionElement;
import org.apache.activemq.artemis.core.postoffice.Binding;
import org.apache.activemq.artemis.core.postoffice.QueueBinding;
-import org.apache.activemq.artemis.core.remoting.CertificateUtil;
+import org.apache.activemq.artemis.utils.CertificateUtil;
Review Comment:
Please reorder the import to the appropriate spot (here most of the other
classes similarly)
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyServerConnection.java:
##########
@@ -54,6 +57,14 @@ public String getRouter() {
return router;
}
+ public X509Certificate[] getCertificates() {
+ return certificates;
+ }
+
+ public void setCertificates(X509Certificate[] certificates) {
+ this.certificates = certificates;
+ }
Review Comment:
I don't think a setter for this really fits here either even though its
server-specific now. This it can all be done within the getter much as it was
in your previous commit. Instead of moving the method impl out of
CertificateUtil, now that youve moved CertificateUtil itself to the server
module you can just make getCertsFromChannel public and call it from the
updated getter here.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyServerConnection.java:
##########
@@ -54,6 +57,14 @@ public String getRouter() {
return router;
}
+ public X509Certificate[] getCertificates() {
+ return certificates;
+ }
Review Comment:
getPeerCertificates might be a clearer name, more in keeping with the
underlying session method called to get the values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
