JeanLucGraphalo commented on code in PR #5956:
URL: https://github.com/apache/activemq-artemis/pull/5956#discussion_r2422814005


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java:
##########
@@ -219,6 +220,16 @@ default void disconnect(DisconnectReason reason, String 
targetNodeID, TransportC
     */
    Subject getSubject();
 
+   /**
+    * sets the associated certificates for this connection
+    */
+   void setCertificates(X509Certificate[] certificates);

Review Comment:
   I pushed a new version that doesn't touch the RemotingConnection, but caches 
certificates in the NettyConnection. I also moved the code associated only to 
the NettyConnection from CertificateUtil to NettyConnection, as proposed.
   
   Is that what you had in mind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to