clebertsuconic commented on code in PR #6009:
URL: https://github.com/apache/activemq-artemis/pull/6009#discussion_r2466957363
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2396,10 +2408,20 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
final String senderName,
final boolean noAutoCreateQueue,
final RoutingContext
routingContext) throws Exception {
+ return doSend(tx, msg.getRoutingType(), msg, originalAddress, direct,
senderName, noAutoCreateQueue, routingContext);
+ }
- RoutingStatus result = RoutingStatus.OK;
+ @Override
+ public synchronized RoutingStatus doSend(final Transaction tx,
+ final RoutingType routingType,
+ final Message message,
+ final SimpleString originalAddress,
+ final boolean direct,
+ final String senderName,
+ final boolean noAutoCreateQueue,
+ final RoutingContext
routingContext) throws Exception {
- RoutingType routingType = msg.getRoutingType();
+ RoutingStatus result = RoutingStatus.OK;
/* TODO-now: How to address here with AMQP?
Review Comment:
Everything looks good.
my only comment on the PR is that I think this comment here should be
removed now.
you are already dealing with the routingType... so this can be removed IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
