tabish121 commented on PR #6009: URL: https://github.com/apache/activemq-artemis/pull/6009#issuecomment-3453161462
> @tabish121 nicely done... > > my only comment is. can you remove these lines now that you are properly dealing with the routingType on AMQP? > > https://github.com/apache/activemq-artemis/blob/12d45767cb762f4105e041fe8c3e70595dfcb42e/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java#L2404-L2411 > > We don't even have prefixes any more.. > > this was a question back then about the routing type on the message versus the link. No more questions as of today after your commit. I'm happy to remove them. I left them as I was trying to minimize the footprint of the change but they don't make a ton of sense as the code has been checking prefix values elsewhere for years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
