clebertsuconic commented on code in PR #6066: URL: https://github.com/apache/activemq-artemis/pull/6066#discussion_r2527800287
########## artemis-core-client/src/main/java/org/apache/activemq/artemis/core/settings/impl/DiskFullMessagePolicy.java: ########## @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.artemis.core.settings.impl; + +public enum DiskFullMessagePolicy { Review Comment: @iliya-gr I added PageFullMessagePolicy as part of [ARTEMIS-3178](https://issues.apache.org/jira/browse/ARTEMIS-3178). I wonder if we need a separate option between DiskFull and PageFull. The only difference here I see is that pageFull is on a hard limit... But I am thinking, for the sake of easy of usage.. we should just use the same option here, and not add a new option... (keep everything you did, but just don't add a new configuration option). I mean.. if disk is full, I would consider Page as as being full, and we should either drop of fail based on that already existing option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
