cshannon commented on PR #1659: URL: https://github.com/apache/activemq/pull/1659#issuecomment-3910073620
So the message is copied during dispatch inside of ActiveMQConnection. If there are multiple connections then it's possible that the message could be copied more than once at the same time, but the copy doesn't mutate state of the original message so this shouldn't cause the issue. So really it comes down to, where (if at all) is the broker touching the message at the same time in 2+ threads that could cause the bug? Or is this just an issue somewhere in the client code etc. The changes in clearUnmarshalledState() to check if the content is null may be worthwhile but in the code we always first check that the content is marshaled first before calling it so not sure that actually helps the real broker. It helps the unit test because that method is called directly. @tabish121 - I know you worked on some of the transport stuff back in the day, do you have any thoughts on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
