pradeep85841 commented on PR #1659: URL: https://github.com/apache/activemq/pull/1659#issuecomment-3910230169
Thanks for the insights, @tabish121. That context on the VM transport and the non-thread-safe nature of OpenWire commands makes a lot of sense. It sounds like while 'Copy First' is the required pattern for users, the current clearUnmarshalledState() implementation has a 'window of vulnerability' where it can accidentally wipe data if the timing is off (as seen in my unit test). By ensuring storeContent() is called before nulling the text field, we’re essentially making the message command 'fail-safe' against that specific state where both fields end up null. I've removed the synchronized keywords to avoid adding overhead to the standard single-threaded path, but kept this logic fix to harden the message against the concurrent scenarios @tabish121 mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
