cshannon commented on PR #1740:
URL: https://github.com/apache/activemq/pull/1740#issuecomment-4025908356

   @jbonofre -
   
   Usually the timeout is set on a Connection and then passed when making the 
request as seen [at this 
line](https://github.com/apache/activemq/blob/6060f9bcd3b38c47225db1162260be6309590c44/activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java#L1466).
   
   Maybe we need to be passing the timeout value in more spots?  I think the 
code just defaults to 0 and not set in many places so the timeout is not used. 
I'm also not a huge fan of system properties as they are global and can't be 
easily set for a single connection, for example unless there is no other option.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to