tabish121 commented on PR #1740: URL: https://github.com/apache/activemq/pull/1740#issuecomment-4026102159
> > @cshannon it's my new work on an old issue from Jira ([AMQ-6763](https://issues.apache.org/jira/browse/AMQ-6763)). I was able to reproduce it when using XA: the broker never sent back a response to these XA commands. > > Looking at it closer, it's getting stuck here in [setXid() ](https://github.com/apache/activemq/blob/6060f9bcd3b38c47225db1162260be6309590c44/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L759) when calling syncSendPacket() on the connection. > > If you want to add a new configuration option for a default timeout I think you should move it one step deeper into the ActiveMQConnection, inside the [syncSendPacket()](https://github.com/apache/activemq/blob/6060f9bcd3b38c47225db1162260be6309590c44/activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java#L1512) method. > > You can replace the 0 that is passed with a new configuration option (that will of course be 0 by default for compatibility). The configuration option can be configured on the connection as a URL parameter or setter like any other connection property and we can avoid the system property and also avoid having the timeout stuff in different locations. > > There's already a [closeTimeout](https://github.com/apache/activemq/blob/6060f9bcd3b38c47225db1162260be6309590c44/activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java#L157) so this could fit in with that and be called something like `requestTimeout` that defaults to 0. There's also a sendTimeout and possibly a connectTimeout in ActiveMQConnection. I recall adding sendTimeout a long time ago for similar reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
