mattrpav commented on code in PR #2136:
URL: https://github.com/apache/activemq/pull/2136#discussion_r3454055263
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2363,7 +2399,20 @@ protected void assignGroup(Subscription subs,
MessageGroupMap messageGroupOwners
}
protected void pageInMessages(boolean force, int maxPageSize) throws
Exception {
- doDispatch(doPageInForDispatch(force, true, maxPageSize));
+ Map<QueueMessageReference, ActiveMQMessageFormatException>
messageFormatErrors = new LinkedHashMap<>();
Review Comment:
see note on deferring map allocation
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -593,7 +597,8 @@ public void removeSubscription(ConnectionContext context,
Subscription sub, long
}
// AMQ-5107: don't resend if the broker is shutting down
if (dispatchPendingList.hasRedeliveries() && (!
this.brokerService.isStopping())) {
- doDispatch(new OrderedPendingList());
+ messageFormatErrors = new LinkedHashMap<>();
Review Comment:
Can map allocation be deferred? This would create a lot of allocation+gc for
the _vast_ majority of the time there is never a messageFormat error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
