cshannon commented on code in PR #2136:
URL: https://github.com/apache/activemq/pull/2136#discussion_r3454555620
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -593,7 +597,8 @@ public void removeSubscription(ConnectionContext context,
Subscription sub, long
}
// AMQ-5107: don't resend if the broker is shutting down
if (dispatchPendingList.hasRedeliveries() && (!
this.brokerService.isStopping())) {
- doDispatch(new OrderedPendingList());
+ messageFormatErrors = new LinkedHashMap<>();
Review Comment:
@tabish121 and @mattrpav - Ok i fixed it by using an instance map to capture
an errors under the lock. if should almost always just be an empty and not
cause any new allocations or GC. If for that page in run it finds some errors
it copies to a new map under lock so we can handle it outside the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
