mattrpav commented on PR #2281:
URL: https://github.com/apache/activemq/pull/2281#issuecomment-5180874360

   Double-check is a good pattern. There is also some inconsistency with how 
the call for onMessageNoConsumers is called. Further down after checking the 
dispatchPolicy, there is a call outside the consumers monitor.
   
   ```
   if (!dispatchPolicy.dispatch(message, msgContext, consumers)) {
       onMessageWithNoConsumers(context, message);
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to