mattrpav commented on PR #2281: URL: https://github.com/apache/activemq/pull/2281#issuecomment-5205243870
@cshannon what are your thoughts on aligning the call sites for 'onMessageWithNoConsumers'? Currently, that is a protected method on BaseDestination, so not really a 'pluggable' entry point there. It does call up to the broker onMessageWithNoConsumers, which is pluggable, so your comment about being called within the state of there being no consumers is correct; however, the inconsistency of the call sites shows that is an incomplete contract of sorts. Side note -- From a design perspective, this should probably be relocated to the DeadLetterStrategy as it is in the same category of 'I got a message and currently no plans to do anything with it' type deal to provide a way to plugin at the destination layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
