mwashburn2 opened a new issue, #2701: URL: https://github.com/apache/activemq/issues/2701
Follow-up to review comments on #2697. `TcpTransport.initialiseSocket` has three long-standing problems: 1. **`socket.*` options target the wrong socket.** `IntrospectionSupport.setProperties` is applied to the `socket` field instead of the `sock` parameter passed to `initialiseSocket`. 2. **`socketBufferSize` silently overwrites `socket.receiveBufferSize` / `socket.sendBufferSize`.** The `socket.*` options are applied first, then the `socketBufferSize` (default 64KB) calls run, so URI values are always replaced. This ordering dates back to AMQ-933 (2006). 3. **Buffer sizes are set after `connect()`.** The TCP window scale is negotiated during the handshake, so a receive buffer > 64KB set after connect does not take full effect. Observed with an embedded broker on main: `socket.receiveBufferSize=262144` ends up as 65536, and `rcv_space` stays at 65495. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
