mwashburn2 opened a new pull request, #2702: URL: https://github.com/apache/activemq/pull/2702
Fixes #2701. - `socket.*` URI options are applied to the `sock` being initialised, not the `socket` field. - `socket.receiveBufferSize` / `socket.sendBufferSize` now take precedence over `socketBufferSize`, per direction (e.g. `socketBufferSize=131072&socket.receiveBufferSize=524288` gives 512K receive / 128K send). - For plain client sockets, buffer sizes are set before `connect()` so window scaling is negotiated correctly. SSL client and broker-accepted sockets are already connected when created, so this does not apply to them. **Compatibility:** configs that set both `socket.*Buffersize` and relied on `socketBufferSize` (or its 64KB default) overriding them will now get the `socket.*` value. **Embedded-broker check (main vs this PR):** | URI | main | this PR | |---|---|---| | `socket.receiveBufferSize=262144` | 64K, rcv_space 65495 | 256K, rcv_space 196661 | | `socketBufferSize=262144` | rcv_space 65495 | rcv_space 196661 | | `socketBufferSize=131072&socket.receiveBufferSize=524288` | 64K/128K | 512K recv / 128K send, rcv_space 458805 | New `TcpTransportSocketOptionsTest` (4 tests) fails on main and passes here; `TransportUriTest` passes. Overlaps #2697 on handling of `socketBufferSize` 0/negative; will rebase whichever lands second. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
