pkumarsinha commented on a change in pull request #951: HIVE-22997 : Copy
external table to target during Repl Dump operation
URL: https://github.com/apache/hive/pull/951#discussion_r393432287
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
##########
@@ -397,17 +397,19 @@ public void externalTableWithPartitions() throws
Throwable {
primary.run("use " + primaryDbName)
.run("insert into table t2 partition(country='france') values
('lyon')")
.run("alter table t2 set location '" + tmpLocation2 + "'")
- .dump(primaryDbName);
+ .dump(primaryDbName, withClause);
- replica.load(replicatedDbName, primaryDbName, loadWithClause);
+ replica.load(replicatedDbName, primaryDbName, withClause);
assertTablePartitionLocation(primaryDbName + ".t2", replicatedDbName +
".t2");
}
@Test
public void externalTableIncrementalReplication() throws Throwable {
- WarehouseInstance.Tuple tuple = primary.dumpWithCommand("repl dump " +
primaryDbName);
+ List<String> withClause = externalTableBasePathWithClause();
+ String replDumpCommand = "repl dump " + primaryDbName
+ + " WITH (" + withClause.get(0) + "," + withClause.get(1) + ")";
+ WarehouseInstance.Tuple tuple = primary.dumpWithCommand(replDumpCommand);
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
