pkumarsinha commented on a change in pull request #951: HIVE-22997 : Copy
external table to target during Repl Dump operation
URL: https://github.com/apache/hive/pull/951#discussion_r393436614
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -367,13 +379,14 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
// Dump external table locations if required.
if (TableType.EXTERNAL_TABLE.equals(table.getTableType())
&& shouldDumpExternalTableLocation()) {
- writer.dataLocationDump(table);
+ extTableLocations.addAll(writer.dataLocationDump(table));
}
// Dump the table to be bootstrapped if required.
if (shouldBootstrapDumpTable(table)) {
HiveWrapper.Tuple<Table> tableTuple = new HiveWrapper(hiveDb,
dbName).table(table);
- dumpTable(dbName, tableName, validTxnList, dbRoot, dumpRoot,
bootDumpBeginReplId, hiveDb, tableTuple);
+ replPathMappings.addAll(dumpTable(dbName, tableName,
validTxnList, dbRoot, dumpRoot, bootDumpBeginReplId,
Review comment:
That's the existing issue with the way current iterators are being used and
the patch doesn't address that. May be later, we may want to solve that in
general. May be by using some disk based iterators. Will file a tracking JIRA
for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
