pkumarsinha commented on a change in pull request #949: HIVE-22990 Add file
based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393780241
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -286,6 +277,7 @@ a database ( directory )
// Populate the driver context with the scratch dir info from the repl
context, so that the temp dirs will be cleaned up later
context.getFsScratchDirs().putAll(loadContext.pathInfo.getFsScratchDirs());
+ createReplLoadCompleteAckTask();
Review comment:
1) During incremental when there is only bootstrap task and no events, this
might not reach here, it will go back right from Line 436: return
executeBootStrapLoad();
2) How does it make sure that the ack task is added after the Repl event ID
update task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
