pkumarsinha commented on a change in pull request #949: HIVE-22990 Add file
based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393848763
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -429,36 +428,19 @@ private Path getCurrentLoadPath() throws IOException,
SemanticException {
}
FileStatus[] statuses =
loadPathBase.getFileSystem(conf).listStatus(loadPathBase);
if (statuses.length > 0) {
- //sort based on last modified. Recent one is at the end
- Arrays.sort(statuses, new Comparator<FileStatus>() {
- public int compare(FileStatus f1, FileStatus f2) {
- return Long.compare(f1.getModificationTime(),
f2.getModificationTime());
+ //sort based on last modified. Recent one is at the beginning
+ FileStatus latestUpdatedStatus = statuses[0];
+ for (FileStatus status : statuses) {
+ if (status.getModificationTime() >
latestUpdatedStatus.getModificationTime()) {
+ latestUpdatedStatus = status;
}
- });
- if (replScope.getDbName() != null) {
- String currentReplStatusOfTarget
- = getReplStatus(replScope.getDbName());
- if (currentReplStatusOfTarget == null) { //bootstrap
- return new Path(statuses[0].getPath(), ReplUtils.REPL_HIVE_BASE_DIR);
- } else {
- DumpMetaData latestDump = new DumpMetaData(
- new Path(statuses[statuses.length - 1].getPath(),
ReplUtils.REPL_HIVE_BASE_DIR), conf);
- if (Long.parseLong(currentReplStatusOfTarget.trim()) >=
latestDump.getEventTo()) {
- isTargetAlreadyLoaded = true;
- } else {
- for (FileStatus status : statuses) {
- Path hiveLoadPath = new Path(status.getPath(),
ReplUtils.REPL_HIVE_BASE_DIR);
- DumpMetaData dmd = new DumpMetaData(hiveLoadPath, conf);
- if (dmd.isIncrementalDump()
- && Long.parseLong(currentReplStatusOfTarget.trim()) <
dmd.getEventTo()) {
- return hiveLoadPath;
- }
- }
- }
+ }
+ Path hiveDumpPath = new Path(latestUpdatedStatus.getPath(),
ReplUtils.REPL_HIVE_BASE_DIR);
+ if (loadPathBase.getFileSystem(conf).exists(hiveDumpPath)) {
Review comment:
Why do we need this check? Aren't other two checks below good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
