sam-an-cloudera commented on a change in pull request #1221:
URL: https://github.com/apache/hive/pull/1221#discussion_r456596312
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java
##########
@@ -123,13 +123,13 @@ public void testGetPartitionsByNamesEmptyParts() throws
Exception {
getClient().getPartitionsByNames(DB_NAME, TABLE_NAME,
Lists.newArrayList("", ""));
}
- @Test(expected = MetaException.class)
+ @Test
Review comment:
I don't recall why we (Ramesh and I) made the change in downstream here,
but I will see if it can be reverted. I didn't change HMS API per se. The
MetaException could be thrown from getPartitionsByNames before my changes.
Those are tests only.
Any way, let me see if I can change to the way the tests were ,and if not,
will give justification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
