sam-an-cloudera commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r456596817
########## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ########## @@ -416,7 +417,7 @@ public void testGetPartitionsByNamesNullDbName() throws Exception { createTable3PartCols1Part(client); client.getPartitionsByNames(null, TABLE_NAME, Lists.newArrayList("yyyy=2000/mm=01/dd=02")); fail("Should have thrown exception"); - } catch (NullPointerException | TTransportException e) { + } catch (NullPointerException | TTransportException | MetaException e) { Review comment: coalesce with above as 1 single test issue. ########## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ########## @@ -427,7 +428,7 @@ public void testGetPartitionsByNamesNullTblName() throws Exception { createTable3PartCols1Part(client); client.getPartitionsByNames(DB_NAME, null, Lists.newArrayList("yyyy=2000/mm=01/dd=02")); fail("Should have thrown exception"); - } catch (NullPointerException | TTransportException e) { + } catch (NullPointerException | TTransportException | TProtocolException | MetaException e ) { Review comment: coalesce with above as 1 single test issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org