belugabehr commented on a change in pull request #1241:
URL: https://github.com/apache/hive/pull/1241#discussion_r461565573



##########
File path: .travis.yml
##########
@@ -24,17 +23,14 @@ dist: bionic
 
 language: java
 jdk:
-  - openjdk8
-
-# disabling cache for 
/home/travis/.m2/repository/org/apache/hive/hive-jdbc/3.0.0-SNAPSHOT/hive-jdbc-3.0.0-SNAPSHOT-standalone.jar
 (Permission denied)
-#cache:
-#  directories:
-#  - $HOME/.m2
+  - openjdk11
 
 env:
   MAVEN_SKIP_RC=true
   MAVEN_OPTS="-Xmx2g"
 
 install: skip
 
-script: mvn clean install -DskipTests -q -Pitests
+before_script: mvn --version

Review comment:
       Ya, sorry, I mean from a feature standpoint : Travis v.s. Jenkins

##########
File path: .travis.yml
##########
@@ -24,17 +23,14 @@ dist: bionic
 
 language: java
 jdk:
-  - openjdk8
-
-# disabling cache for 
/home/travis/.m2/repository/org/apache/hive/hive-jdbc/3.0.0-SNAPSHOT/hive-jdbc-3.0.0-SNAPSHOT-standalone.jar
 (Permission denied)
-#cache:
-#  directories:
-#  - $HOME/.m2
+  - openjdk11
 
 env:
   MAVEN_SKIP_RC=true
   MAVEN_OPTS="-Xmx2g"
 
 install: skip
 
-script: mvn clean install -DskipTests -q -Pitests
+before_script: mvn --version

Review comment:
       Ya, sorry, I mean from a feature standpoint : Travis v.s. Jenkins
   
   Can Travis run tests?  If so, why setup this special purpose docker 
container when the same can be done more simply with Travis?

##########
File path: Jenkinsfile
##########
@@ -81,6 +81,7 @@ def buildHive(args) {
   configFileProvider([configFile(fileId: 'artifactory', variable: 
'SETTINGS')]) {
     withEnv(["MULTIPLIER=$params.MULTIPLIER","M_OPTS=$params.OPTS"]) {
       sh '''#!/bin/bash -e
+sw java 11

Review comment:
       @kgyrtkirk 
   ```
   Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) 
on project hive-storage-api: Fatal error compiling: invalid target release: 11 
-> [Help 1]
   ```
   This didn't seem to work.
   
   
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-1241/5/pipeline




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to