ashutoshc commented on pull request #1241: URL: https://github.com/apache/hive/pull/1241#issuecomment-665358916
My suggestion would be to split the changes in separate tickets. Ticket for code changes which are necessary for jdk11 but can be committed before the actual move to jdk11 like hadoop class/version, dependency exclusion, dependency upgrades etc. Commit those first and then have minimal changes after that just changes the compile and runtime version to 11. Advantage of doing it that way is it will make it easier downstream to cherry-pick up these changes if they are separate commits. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
