mustafaiman commented on a change in pull request #1352:
URL: https://github.com/apache/hive/pull/1352#discussion_r464523610
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -514,7 +526,8 @@ private void
prepareBatchAggregationBufferSets(VectorizedRowBatch batch) throws
// is very important to clone the keywrapper, the one we have from
our
// keyWrappersBatch is going to be reset/reused on next batch.
aggregationBuffer = allocateAggregationBuffer();
Review comment:
@rbalamohan I have another patch for that.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -514,7 +526,8 @@ private void
prepareBatchAggregationBufferSets(VectorizedRowBatch batch) throws
// is very important to clone the keywrapper, the one we have from
our
// keyWrappersBatch is going to be reset/reused on next batch.
aggregationBuffer = allocateAggregationBuffer();
Review comment:
@rbalamohan I have another patch for that:
https://github.com/apache/hive/pull/1337/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
