deniskuzZ commented on a change in pull request #1592:
URL: https://github.com/apache/hive/pull/1592#discussion_r514979640
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1526,6 +1529,10 @@ private void
updateWSCommitIdAndCleanUpMetadata(Statement stmt, long txnid, TxnT
if (txnType == TxnType.MATER_VIEW_REBUILD) {
queryBatch.add("DELETE FROM \"MATERIALIZATION_REBUILD_LOCKS\" WHERE
\"MRL_TXN_ID\" = " + txnid);
}
+ if (txnType == TxnType.COMPACTION) {
Review comment:
I think, you could make `updateWSCommitIdAndCleanUpMetadata` protected
and overwrite it in CompactionTxnHandler, so we won't scatter compaction
related stuff across many classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
