klcopp commented on a change in pull request #1592:
URL: https://github.com/apache/hive/pull/1592#discussion_r516037677



##########
File path: 
ql/src/test/results/clientpositive/llap/cardinality_preserving_join_opt2.q.out
##########
@@ -239,7 +239,7 @@ HiveProject(c1=[$11], c5=[$13], c6=[$14], c3=[$1], c4=[$2], 
c51=[$3], c61=[$4],
             HiveFilter(condition=[IS NOT NULL($0)])
               HiveTableScan(table=[[mydb_e10, d4_tab_e10]], table:alias=[r])
         HiveProject(c1=[$0], c2=[$1], c4=[$3], c5=[$4])
-          HiveFilter(condition=[AND(OR(IS NULL($4), >($4, 2020-10-01)), IS NOT 
NULL($1), IS NOT NULL($0))])

Review comment:
       You can revert this, I disabled it a minute ago.

##########
File path: 
ql/src/test/results/clientpositive/llap/cardinality_preserving_join_opt2.q.out
##########
@@ -239,7 +239,7 @@ HiveProject(c1=[$11], c5=[$13], c6=[$14], c3=[$1], c4=[$2], 
c51=[$3], c61=[$4],
             HiveFilter(condition=[IS NOT NULL($0)])
               HiveTableScan(table=[[mydb_e10, d4_tab_e10]], table:alias=[r])
         HiveProject(c1=[$0], c2=[$1], c4=[$3], c5=[$4])
-          HiveFilter(condition=[AND(OR(IS NULL($4), >($4, 2020-10-01)), IS NOT 
NULL($1), IS NOT NULL($0))])

Review comment:
       And rebase of course




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to