pkumarsinha commented on a change in pull request #1648:
URL: https://github.com/apache/hive/pull/1648#discussion_r520303172
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -82,27 +87,31 @@ public void copyAndVerify(Path destRoot,
List<ReplChangeManager.FileInfo> srcFil
}
FileSystem sourceFs = srcFiles.get(0).getSrcFs();
boolean useRegularCopy = regularCopy(sourceFs, srcFiles);
+ ExecutorService executorService = null;
try {
if (useRegularCopy || readSrcAsFilesList) {
+ executorService = Executors.newFixedThreadPool(maxParallelCopyTask);
Review comment:
yes, but none of the existing test cover the fact that we started using
threadpool. How do we know if threadpool is operational, the size was adhered
to etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
