aasha commented on a change in pull request #1648:
URL: https://github.com/apache/hive/pull/1648#discussion_r520324062
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -82,27 +87,31 @@ public void copyAndVerify(Path destRoot,
List<ReplChangeManager.FileInfo> srcFil
}
FileSystem sourceFs = srcFiles.get(0).getSrcFs();
boolean useRegularCopy = regularCopy(sourceFs, srcFiles);
+ ExecutorService executorService = null;
try {
if (useRegularCopy || readSrcAsFilesList) {
+ executorService = Executors.newFixedThreadPool(maxParallelCopyTask);
Review comment:
Is that not part of executor service implementation?
If functionally copy is working for both file counts >1 and =1 we know that
our threadpool is operational. These tests are already present in replication
test suite.
Adhering to size etc is specific to the executor service and not implemented
by us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
