viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736018282
> Thanks @viirya ! the new PR looks almost good to me except one nit. > > Also comparing to the original patch, we don't have changes to `HiveRelDecorrelator`, `HiveAggregate` and `HiveSubQueryRemoveRule`. This is unnecessary because we've shaded Guava within `hive-exec`? (some of the APIs like `operandJ` do not exist in the Calcite version used by branch-2.3 also). The change to `HiveAggregate` just to remove unused parameter `groupSets` in `deriveRowType`. Not related to shading guava, so I don't apply it. The change from `operand` to `operandJ` in `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`, cannot apply to branch-2.3 because `operandJ` is not in calcite 1.10.0. The API was add since calcite 1.17.0 (https://github.com/apache/calcite/commit/d59b639d/). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
