viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736192230
> Yes, my main question is whether it is safe to skip the changes on `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`. It looks fine to me since we've already shaded calcite within hive/ql. Yeah, it should be fine. Calcite uses guava API so shading guava causes no method error if we don't include calcite in shaded jar of hive/ql. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
