pvargacl commented on a change in pull request #1738:
URL: https://github.com/apache/hive/pull/1738#discussion_r535939329
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1369,14 +1383,14 @@ private static Directory getAcidState(FileSystem
fileSystem, Path candidateDirec
if (childrenWithId != null) {
for (HdfsFileStatusWithId child : childrenWithId) {
getChildState(child, writeIdList, working, originalDirectories,
original, obsolete,
- bestBase, ignoreEmptyFiles, abortedDirectories, abortedWriteIds,
fs, validTxnList);
+ bestBase, ignoreEmptyFiles, abortedDirectories, abortedWriteIds,
uncompactedAborts, fs, validTxnList);
Review comment:
In a follow up Jira it might be worth change this whole AcidUtils
approach and start to put everything from the beginning in a DirectoryImpl, so
the argument count could be decreased to a sane amount.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
