pvargacl commented on a change in pull request #1738:
URL: https://github.com/apache/hive/pull/1738#discussion_r537329142
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -566,20 +567,20 @@ else if (filename.startsWith(BUCKET_PREFIX)) {
public static final class DirectoryImpl implements Directory {
private final List<Path> abortedDirectories;
private final Set<Long> abortedWriteIds;
+ private final boolean uncompactedAborts;
private final boolean isBaseInRawFormat;
private final List<HdfsFileStatusWithId> original;
private final List<Path> obsolete;
private final List<ParsedDelta> deltas;
private final Path base;
private List<HdfsFileStatusWithId> baseFiles;
- public DirectoryImpl(List<Path> abortedDirectories, Set<Long>
abortedWriteIds,
- boolean isBaseInRawFormat, List<HdfsFileStatusWithId> original,
- List<Path> obsolete, List<ParsedDelta> deltas, Path base) {
- this.abortedDirectories = abortedDirectories == null ?
- Collections.emptyList() : abortedDirectories;
- this.abortedWriteIds = abortedWriteIds == null ?
- Collections.emptySet() : abortedWriteIds;
+ public DirectoryImpl(List<Path> abortedDirectories, Set<Long>
abortedWriteIds, boolean uncompactedAborts,
Review comment:
Yes, I plan to do that. I think I will make DirectoryImpl mutable, and
pass it down the getAcidState calls, to gather all the info in it along the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
