jcamachor commented on a change in pull request #1811:
URL: https://github.com/apache/hive/pull/1811#discussion_r548344387
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
##########
@@ -728,6 +769,134 @@ private void applyFilterTransitivity(JoinOperator join,
int targetPos, OpWalkerI
}
}
}
+
+ private void extractColumnExprNodes(ExprNodeDesc exprNodeDesc,
List<ExprNodeColumnDesc> result) {
+ if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+ result.add((ExprNodeColumnDesc) exprNodeDesc);
+ return;
+ }
+ if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+ for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+ extractColumnExprNodes(child, result);
+ }
+ }
+ }
+
+ private ExprNodeDesc replaceColumnExprNodes(ExprNodeDesc exprNodeDesc,
Map<ExprNodeDesc, ExprNodeDesc> replaceMap) {
+ if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+ return replaceMap.getOrDefault(exprNodeDesc, exprNodeDesc);
+ }
+ if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+ ExprNodeGenericFuncDesc exprNodeGenericFuncDesc =
(ExprNodeGenericFuncDesc) exprNodeDesc.clone();
+ List<ExprNodeDesc> replacedChildren = new
ArrayList<>(exprNodeDesc.getChildren().size());
+ for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+ replacedChildren.add(replaceColumnExprNodes(child, replaceMap));
+ }
+ exprNodeGenericFuncDesc.setChildren(replacedChildren);
+ return exprNodeGenericFuncDesc;
+ }
+
+ return exprNodeDesc;
+ }
+
+ private Map<ExprNodeDesc, String> walk(Operator<?> operator,
List<ExprNodeColumnDesc> exprNodeDescList) {
+ Map<ExprNodeDesc, String> equalities;
+ if (operator instanceof CommonJoinOperator) {
+ equalities = processJoinEq((CommonJoinOperator<?>)operator,
exprNodeDescList);
+ } else {
+ equalities = processDefaultEq(operator, exprNodeDescList);
+ }
+ return equalities;
+ }
+
+ private Map<ExprNodeDesc, String> processJoinEq(
+ CommonJoinOperator<?> join, List<ExprNodeColumnDesc>
exprNodeDescList) {
+ if (exprNodeDescList.isEmpty()) {
+ return Collections.emptyMap();
+ }
+ Map<ExprNodeDesc, String> equalities = new HashMap<>();
+ for (ExprNodeColumnDesc exprNodeDesc : exprNodeDescList) {
+ ExprNodeDesc mappedColExpr =
join.getColumnExprMap().get(exprNodeDesc.getColumn());
+ if (!(mappedColExpr instanceof ExprNodeColumnDesc)) {
+ continue;
+ }
+ String mappedColName = ((ExprNodeColumnDesc)mappedColExpr).getColumn();
+ int sideIndex =
join.getConf().getReversedExprs().get(exprNodeDesc.getColumn());
+ Operator<?> parentRSOperator =
join.getParentOperators().get(sideIndex);
+ for (int i = 0; i < join.getConf().getJoinKeys()[sideIndex].length;
++i) {
+ ExprNodeDesc keyExpr = join.getConf().getJoinKeys()[sideIndex][i];
+ if
(!keyExpr.isSame(parentRSOperator.getColumnExprMap().get(mappedColName))) {
+ continue;
+ }
+
+ // exprNodeDesc is join key
+ // find the other key in the join expression
+ Operator<?> otherParentRSOperator = join.getParentOperators().get(1
- sideIndex);
+ for (Entry<String, ExprNodeDesc> joinMapEntry :
join.getColumnExprMap().entrySet()) {
+ if (join.getConf().getReversedExprs().get(joinMapEntry.getKey())
!= 1 - sideIndex) {
+ continue;
+ }
+
+ String otherColumnName = ((ExprNodeColumnDesc)
joinMapEntry.getValue()).getColumn();
+ ExprNodeDesc mappedOtherKeyExpr =
otherParentRSOperator.getColumnExprMap().get(otherColumnName);
+ ExprNodeDesc otherKeyExpr = join.getConf().getJoinKeys()[1 -
sideIndex][i];
+ if (mappedOtherKeyExpr != null &&
otherKeyExpr.isSame(mappedOtherKeyExpr)) {
+ equalities.put(exprNodeDesc, joinMapEntry.getKey());
+ }
+ }
+ }
+ }
+
+ for (Operator<?> parent : join.getParentOperators()) {
+ equalities.putAll(walk(parent, exprNodeDescList));
+ }
+
+ return equalities;
+ }
+
+ private Map<ExprNodeDesc, String> processDefaultEq(
+ Operator<?> operator, List<ExprNodeColumnDesc> exprNodeDescList) {
+ if (exprNodeDescList.isEmpty()) {
+ return Collections.emptyMap();
+ }
+
+ Map<String, ExprNodeDesc> columnExprMap = operator.getColumnExprMap();
+ if (columnExprMap == null) {
Review comment:
When would this be null? Can we add a comment?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
##########
@@ -728,6 +769,134 @@ private void applyFilterTransitivity(JoinOperator join,
int targetPos, OpWalkerI
}
}
}
+
+ private void extractColumnExprNodes(ExprNodeDesc exprNodeDesc,
List<ExprNodeColumnDesc> result) {
+ if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+ result.add((ExprNodeColumnDesc) exprNodeDesc);
+ return;
+ }
+ if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+ for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+ extractColumnExprNodes(child, result);
+ }
+ }
+ }
+
+ private ExprNodeDesc replaceColumnExprNodes(ExprNodeDesc exprNodeDesc,
Map<ExprNodeDesc, ExprNodeDesc> replaceMap) {
+ if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+ return replaceMap.getOrDefault(exprNodeDesc, exprNodeDesc);
+ }
+ if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+ ExprNodeGenericFuncDesc exprNodeGenericFuncDesc =
(ExprNodeGenericFuncDesc) exprNodeDesc.clone();
+ List<ExprNodeDesc> replacedChildren = new
ArrayList<>(exprNodeDesc.getChildren().size());
+ for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+ replacedChildren.add(replaceColumnExprNodes(child, replaceMap));
+ }
+ exprNodeGenericFuncDesc.setChildren(replacedChildren);
+ return exprNodeGenericFuncDesc;
+ }
+
+ return exprNodeDesc;
+ }
+
+ private Map<ExprNodeDesc, String> walk(Operator<?> operator,
List<ExprNodeColumnDesc> exprNodeDescList) {
Review comment:
Consider changing method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
