kasakrisz commented on a change in pull request #1811:
URL: https://github.com/apache/hive/pull/1811#discussion_r564597536



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
##########
@@ -728,6 +769,134 @@ private void applyFilterTransitivity(JoinOperator join, 
int targetPos, OpWalkerI
         }
       }
     }
+
+    private void extractColumnExprNodes(ExprNodeDesc exprNodeDesc, 
List<ExprNodeColumnDesc> result) {
+      if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+        result.add((ExprNodeColumnDesc) exprNodeDesc);
+        return;
+      }
+      if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+        for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+          extractColumnExprNodes(child, result);
+        }
+      }
+    }
+
+    private ExprNodeDesc replaceColumnExprNodes(ExprNodeDesc exprNodeDesc, 
Map<ExprNodeDesc, ExprNodeDesc> replaceMap) {
+      if (exprNodeDesc instanceof ExprNodeColumnDesc) {
+        return replaceMap.getOrDefault(exprNodeDesc, exprNodeDesc);
+      }
+      if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) {
+        ExprNodeGenericFuncDesc exprNodeGenericFuncDesc = 
(ExprNodeGenericFuncDesc) exprNodeDesc.clone();
+        List<ExprNodeDesc> replacedChildren = new 
ArrayList<>(exprNodeDesc.getChildren().size());
+        for (ExprNodeDesc child : exprNodeDesc.getChildren()) {
+          replacedChildren.add(replaceColumnExprNodes(child, replaceMap));
+        }
+        exprNodeGenericFuncDesc.setChildren(replacedChildren);
+        return exprNodeGenericFuncDesc;
+      }
+
+      return exprNodeDesc;
+    }
+
+    private Map<ExprNodeDesc, String> walk(Operator<?> operator, 
List<ExprNodeColumnDesc> exprNodeDescList) {

Review comment:
       changed to `searchForEqualities`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to